Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and fix puppy for metaclient #2870

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

xyuanlu
Copy link
Contributor

@xyuanlu xyuanlu commented Aug 3, 2024

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

#2864 #2863 #2862 #2861 #2860 #2859

Description

  • Here are some details about my PR, including screenshots of any UI changes:

error message we get from CI run:

2024-07-30T21:43:05.0343689Z [ERROR] testDeletePuppy(org.apache.helix.metaclient.impl.zk.TestMultiThreadStressTest.TestMultiThreadStressZKClient)  Time elapsed: 0.001 s  <<< FAILURE!
2024-07-30T21:43:05.0346465Z org.apache.helix.metaclient.exception.MetaClientNodeExistsException: org.apache.helix.zookeeper.zkclient.exception.ZkNodeExistsException: org.apache.zookeeper.KeeperException$NodeExistsException: KeeperErrorCode = NodeExists for /test
2024-07-30T21:43:05.0349365Z 	at org.apache.helix.metaclient.impl.zk.TestMultiThreadStressTest.TestMultiThreadStressZKClient.testDeletePuppy(TestMultiThreadStressZKClient.java:76)
2024-07-30T21:43:05.0351768Z Caused by: org.apache.helix.zookeeper.zkclient.exception.ZkNodeExistsException: org.apache.zookeeper.KeeperException$NodeExistsException: KeeperErrorCode = NodeExists for /test
2024-07-30T21:43:05.0354329Z 	at org.apache.helix.metaclient.impl.zk.TestMultiThreadStressTest.TestMultiThreadStressZKClient.testDeletePuppy(TestMultiThreadStressZKClient.java:76)
2024-07-30T21:43:05.0356414Z Caused by: org.apache.zookeeper.KeeperException$NodeExistsException: KeeperErrorCode = NodeExists for /test
2024-07-30T21:43:05.0359278Z 	at org.apache.helix.metaclient.impl.zk.TestMultiThreadStressTest.TestMultiThreadStressZKClient.testDeletePuppy(TestMultiThreadStressZKClient.java:76)

Refactor and fix puppy for metaclient - isolate tests by using different ZK pathes.

Tests

  • The following tests are written for this issue:

NA

  • The following is the result of the "mvn test" command on the appropriate module:

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

@xyuanlu xyuanlu marked this pull request as ready for review August 3, 2024 06:13
@xyuanlu
Copy link
Contributor Author

xyuanlu commented Aug 5, 2024

This change is ready to be merged. Approved by @junkaixue
Commit message: "Refactor and fix puppy for metaclient"

@xyuanlu xyuanlu merged commit 2add0c4 into apache:master Aug 5, 2024
2 checks passed
htin1 pushed a commit to htin1/helix that referenced this pull request Aug 23, 2024
Refactor and fix puppy for metaclient
htin1 pushed a commit to htin1/helix that referenced this pull request Aug 29, 2024
Refactor and fix puppy for metaclient
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants